MatrixSynapse/synapse
Richard van der Hoff 1bebc0b78c
Clean up federation event auth code (#10539)
* drop old-room hack

pretty sure we don't need this any more.

* Remove incorrect comment about modifying `context`

It doesn't look like the supplied context is ever modified.

* Stop `_auth_and_persist_event` modifying its parameters

This is only called in three places. Two of them don't pass `auth_events`, and
the third doesn't use the dict after passing it in, so this should be non-functional.

* Stop `_check_event_auth` modifying its parameters

`_check_event_auth` is only called in three places. `on_send_membership_event`
doesn't pass an `auth_events`, and `prep` and `_auth_and_persist_event` do not
use the map after passing it in.

* Stop `_update_auth_events_and_context_for_auth` modifying its parameters

Return the updated auth event dict, rather than modifying the parameter.

This is only called from `_check_event_auth`.

* Improve documentation on `_auth_and_persist_event`

Rename `auth_events` parameter to better reflect what it contains.

* Improve documentation on `_NewEventInfo`

* Improve documentation on `_check_event_auth`

rename `auth_events` parameter to better describe what it contains

* changelog
2021-08-06 13:54:23 +01:00
..
_scripts Remove shebang line from module files (#10415) 2021-07-29 21:34:14 +01:00
api
app Remove shebang line from module files (#10415) 2021-07-29 21:34:14 +01:00
appservice
config Add a setting to disable TLS for sending email (#10546) 2021-08-06 10:13:34 +00:00
crypto
events
federation Refactoring before implementing the updated spaces summary. (#10527) 2021-08-05 12:39:17 +00:00
groups
handlers Clean up federation event auth code (#10539) 2021-08-06 13:54:23 +01:00
http
logging Fix PeriodicallyFlushingMemoryHandler inhibiting application shutdown (#10517) 2021-08-03 14:28:30 +01:00
metrics
module_api Add `get_userinfo_by_id` method to `ModuleApi` (#9581) 2021-08-04 10:40:25 +00:00
push Remove shebang line from module files (#10415) 2021-07-29 21:34:14 +01:00
replication
res/templates
rest Mark all MSC2716 events as historical (#10537) 2021-08-05 20:35:53 -05:00
server_notices
spam_checker_api
state
static
storage Add support for MSC2716 marker events (#10498) 2021-08-04 12:07:57 -05:00
streams
util Remove shebang line from module files (#10415) 2021-07-29 21:34:14 +01:00
__init__.py 1.40.0rc2 2021-08-04 17:09:27 +01:00
event_auth.py Fix explicit assignment of PL 0 from being misinterpreted in rare circumstances (#10499) 2021-07-30 12:34:21 +01:00
notifier.py Generics for `ObservableDeferred` (#10491) 2021-07-28 19:55:50 +00:00
python_dependencies.py
server.py Add a setting to disable TLS for sending email (#10546) 2021-08-06 10:13:34 +00:00
types.py Add `get_userinfo_by_id` method to `ModuleApi` (#9581) 2021-08-04 10:40:25 +00:00
visibility.py