OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

basic error handling for malformed quotes 

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
pull/21833/head
Michael Telatynski 2018-01-22 16:41:32 +00:00
parent 3b1d69edbb
commit a6cefb83f8
No known key found for this signature in database
GPG Key ID: 3F879DA5AD802A5E
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/components/views/elements/Quote.js
View File

@ -53,8 +53,8 @@ export default class Quote extends React.Component {
events: [], events: [],
// Whether the top (oldest) event should be shown or spoilered // Whether the top (oldest) event should be shown or spoilered
show: true, show: true,
// Whether an error was encountered fetching another older event, show if it does // Whether an error was encountered fetching nested older event, show node if it does
err: null, err: false,
}; };
this.onQuoteClick = this.onQuoteClick.bind(this); this.onQuoteClick = this.onQuoteClick.bind(this);
@ -124,10 +124,16 @@ export default class Quote extends React.Component {
// addRichQuote(roomId, eventId) { // addRichQuote(roomId, eventId) {
addRichQuote(href) { addRichQuote(href) {
const {roomIdentifier, eventId} = this.parseUrl(href); const {roomIdentifier, eventId} = this.parseUrl(href);
if (!roomIdentifier || !eventId) return; if (!roomIdentifier || !eventId) {
this.setState({ err: true });
return;
}
const room = this.getRoom(roomIdentifier); const room = this.getRoom(roomIdentifier);
if (!room) return; if (!room) {
this.setState({ err: true });
return;
}
this.getEvent(room, eventId, false); this.getEvent(room, eventId, false);
} }