OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Avoid double updating: setting the state will cause a re-render so forcing an update is redundant. Also bump js sdk dep to newest to match vector.

pull/21833/head
David Baker 2015-10-13 11:12:06 +01:00
parent 030124a59a
commit d12ca92ea7
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -24,7 +24,7 @@
"flux": "^2.0.3", "flux": "^2.0.3",
"glob": "^5.0.14", "glob": "^5.0.14",
"linkifyjs": "^2.0.0-beta.4", "linkifyjs": "^2.0.0-beta.4",
"matrix-js-sdk": "^0.2.1", "matrix-js-sdk": "^0.2.2",
"optimist": "^0.6.1", "optimist": "^0.6.1",
"q": "^1.4.1", "q": "^1.4.1",
"react": "^0.13.3", "react": "^0.13.3",

3
src/controllers/organisms/MemberList.js
View File

@ -75,9 +75,6 @@ module.exports = {
if (tile) { if (tile) {
self._updateList(); // reorder the membership list self._updateList(); // reorder the membership list
self.forceUpdate(); // FIXME: is the a more efficient way of reordering with react?
// XXX: do we even need to do this, or is it done by the main list?
tile.forceUpdate();
} }
} }
// FIXME: we should probably also reset 'lastActiveAgo' to zero whenever // FIXME: we should probably also reset 'lastActiveAgo' to zero whenever