Commit Graph

35855 Commits (4755a81403cdfc8ecb46eab7397e04ce87c331dc)

Author SHA1 Message Date
James Salter 4755a81403 Disable analytics when user hasn't opted in or out 2021-08-02 12:23:42 +01:00
James Salter ce11e6c981
Update src/PosthogAnalytics.ts
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
2021-08-02 11:45:49 +01:00
James Salter cd2bc79b6b Remove comment 2021-07-29 14:43:19 +01:00
James Salter a1ffd240e1 Use .instance pattern 2021-07-29 14:40:18 +01:00
James Salter 07eaee25d2 Default properties to {} to avoid passing it superfluously for events with no properties 2021-07-28 17:54:35 +01:00
James Salter d401789f9e Ignore eslint conventions in disastrous posthog type definitions 2021-07-28 17:26:24 +01:00
James Salter 7b4a7711b2 Declare return types for all public methods, even void ones 2021-07-28 17:20:22 +01:00
James Salter e4722ee457 Override posthog type definitions to point to a locally fixed type definition file
Posthog's type definitions refer to types in transitive dependencies we don't want to include.

Clone posthog.d.ts locally, remove the offending types from it, and provide an overriding mapping in tsconfig.

If this proves annoying to maintain, posthog.d.ts could just be an empty file.
2021-07-28 17:14:36 +01:00
James Salter 0a951501b2 lint 2021-07-28 17:04:18 +01:00
James Salter e5d36e9a81 Use arrow function instead of bind 2021-07-28 17:02:26 +01:00
James Salter b1bd5f57a4 Document IEvent.properties, fix IWelcomeScreenLoad
IEvent.properties is a placeholder that needs to be overriden by extenders for type validation to take place.

IWelcomeScreenLoad should have had properties declared for it. Because it didn't, a faulty call using it was possible.
2021-07-28 16:43:13 +01:00
James Salter 13ef819ba6 isEnabled returns a boolean 2021-07-28 16:42:56 +01:00
James Salter ce80e5a463 Remove superfluous unused argument 2021-07-28 14:44:28 +01:00
James Salter 279871ce01 Add types 2021-07-28 14:44:16 +01:00
James Salter df6d772d8d Pin posthog version
We'd like to manually review each posthog change to avoid unanticipated tracking leakages;
each upgrade should include reviewing the data coming in on events
2021-07-28 14:40:32 +01:00
James Salter a687bab52f Use readonly shorthand for posthog param 2021-07-28 14:38:41 +01:00
James Salter 60bc283455 Add return type to getRedactedCurrentLocation 2021-07-28 14:22:57 +01:00
James Salter 9420b81eeb Rename mysterious _ to beforeFirstSlash 2021-07-28 14:22:32 +01:00
James Salter da3bf5a097 rename knownScreens -> whitelistedScreens 2021-07-28 14:15:40 +01:00
James Salter ecbc536a3e Add copyright header 2021-07-28 14:15:27 +01:00
James Salter a09e046c18
Update test/PosthogAnalytics-test.ts
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2021-07-28 14:11:55 +01:00
James Salter d5bef53f8b Use snake case for feature name 2021-07-28 14:03:17 +01:00
James Salter 868d92781d Add copyright header 2021-07-28 14:01:21 +01:00
James Salter df7ebb2e7c Remove commented out block 2021-07-28 14:00:37 +01:00
James Salter 3ff7de3c96 Mock SHA-256 to avoid problems loading crypto on Node 14 2021-07-28 13:44:06 +01:00
James Salter 55e8173ee9 remove whitespace 2021-07-28 12:12:10 +01:00
James Salter d96e7e3375 Add transitive dev dependencies of posthog
This is needed during tsc lint as posthog imports types from these
libraries into its type definitions
2021-07-28 12:08:55 +01:00
James Salter 7cf28de9c9 take 2 at fixing import 2021-07-28 11:32:17 +01:00
James Salter 7c62386915 lint 2021-07-28 11:28:19 +01:00
James Salter c697079eb4 Fix import 2021-07-28 11:22:40 +01:00
James Salter bd7e2dee3d Merge remote-tracking branch 'origin' into posthog-analytics 2021-07-28 11:13:22 +01:00
Germain 771dda0341
Merge pull request #6472 from SimonBrandner/fix/call-view/18221 2021-07-28 11:10:37 +01:00
James Salter 8ef18d0f9a Add module level comment about anonymity behaviour 2021-07-28 11:03:40 +01:00
James Salter c3e715c1ca i18n 2021-07-28 10:45:32 +01:00
James Salter c206127f68 Track screen name when tracking page view 2021-07-28 10:45:03 +01:00
James Salter 4048cb3c37 Default to Anonymous tracking when no OptIn setting is present 2021-07-28 10:20:16 +01:00
James Salter a6df687196 Tidy up interface and add some comments 2021-07-28 09:54:37 +01:00
Germain 2a5577810f
Merge pull request #6485 from matrix-org/gsouquet/fix-18264 2021-07-28 09:41:36 +01:00
James Salter 1d81bdc6f9 Interface changes and anonymity fixes 2021-07-28 09:37:08 +01:00
Germain Souquet a4cf147d72 Merge branch 'develop' into gsouquet/fix-18264 2021-07-28 10:30:29 +02:00
Germain 77a3d2ec18
Merge pull request #6491 from robintown/align-reactions
Realign reactions row with messages in modern layout
2021-07-28 09:16:04 +01:00
Michael Telatynski 98f3a5120c
Merge pull request #6492 from matrix-org/t3chguy/fix/18275.1 2021-07-28 09:10:00 +01:00
Michael Telatynski 52e50863f8 Fix CreateRoomDialog exploding when making public room outside of a space 2021-07-28 08:39:59 +01:00
Robin Townsend 3694006d05 Realign reactions row with messages in modern layout
Signed-off-by: Robin Townsend <robin@robin.town>
2021-07-27 23:48:51 -04:00
Travis Ralston 9707797d45
Merge pull request #6272 from SimonBrandner/fix/explicit-font/14163
Don't set `font-family` explicitly
2021-07-27 11:04:23 -06:00
Germain f82744db97
Merge pull request #6487 from matrix-org/gsouquet/fix-18265 2021-07-27 17:20:02 +01:00
Germain 7e453d7745
Typo
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2021-07-27 17:14:39 +01:00
Michael Telatynski e7151ebf2d
Merge pull request #6488 from SimonBrandner/fix/call-crash/18270 2021-07-27 17:12:01 +01:00
Šimon Brandner 36607fa8a2
Fix call crashing because element was undefined
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2021-07-27 18:05:50 +02:00
Germain Souquet 30ce7b5eab Make link within replies clickable 2021-07-27 17:57:46 +02:00