fix rainbow breaks compound emojis (#8245)

* fix rainbow breaks compound emojis

* use lodash split method for text splitting and add a unit test to test the behaviour

* Update _RichText.scss

* Update colour-test.ts
t3chguy/dedup-icons-17oct
Emmanuel 2022-04-20 15:49:12 +01:00 committed by GitHub
parent 4a38cbd550
commit 9a065581e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 1 deletions

View File

@ -14,10 +14,12 @@ See the License for the specific language governing permissions and
limitations under the License.
*/
import { split } from 'lodash';
export function textToHtmlRainbow(str: string): string {
const frequency = (2 * Math.PI) / str.length;
return Array.from(str)
return split(str, '')
.map((c, i) => {
if (c === " ") {
return c;

24
test/utils/colour-test.ts Normal file
View File

@ -0,0 +1,24 @@
/*
Copyright 2022 Emmanuel Ezeka <eec.studies@gmail.com>
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
import { textToHtmlRainbow } from "../../src/utils/colour";
describe("textToHtmlRainbow", () => {
it('correctly transform text to html without splitting the emoji in two', () => {
expect(textToHtmlRainbow('🐻')).toBe('<font color="#ff00be">🐻</font>');
expect(textToHtmlRainbow('🐕‍🦺')).toBe('<font color="#ff00be">🐕‍🦺</font>');
});
});