OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Only error log url preview failure if not 404 matrix error (#11297)

pull/28788/head^2
Michael Telatynski 2023-07-19 17:03:59 +01:00 committed by GitHub
parent 0c4a5cd7c1
commit dd5b9329e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/components/views/rooms/LinkPreviewGroup.tsx
View File

@ -18,6 +18,7 @@ import React, { useContext, useEffect } from "react";
import { MatrixEvent } from "matrix-js-sdk/src/models/event"; import { MatrixEvent } from "matrix-js-sdk/src/models/event";
import { IPreviewUrlResponse, MatrixClient } from "matrix-js-sdk/src/client"; import { IPreviewUrlResponse, MatrixClient } from "matrix-js-sdk/src/client";
import { logger } from "matrix-js-sdk/src/logger"; import { logger } from "matrix-js-sdk/src/logger";
import { MatrixError } from "matrix-js-sdk/src/matrix";
import { useStateToggle } from "../../../hooks/useStateToggle"; import { useStateToggle } from "../../../hooks/useStateToggle";
import LinkPreviewWidget from "./LinkPreviewWidget"; import LinkPreviewWidget from "./LinkPreviewWidget";
@ -106,7 +107,12 @@ const fetchPreviews = (cli: MatrixClient, links: string[], ts: number): Promise<
return [link, preview]; return [link, preview];
} }
} catch (error) { } catch (error) {
logger.error("Failed to get URL preview: " + error); if (error instanceof MatrixError && error.httpStatus === 404) {
// Quieten 404 Not found errors, not all URLs can have a preview generated
logger.debug("Failed to get URL preview: ", error);
} else {
logger.error("Failed to get URL preview: ", error);
}
} }
}), }),
).then((a) => a.filter(Boolean)) as Promise<[string, IPreviewUrlResponse][]>; ).then((a) => a.filter(Boolean)) as Promise<[string, IPreviewUrlResponse][]>;