Commit Graph

45768 Commits (56e4ae41f8ae06077e47bd674f500de677f28e4c)

Author SHA1 Message Date
Michael Telatynski 56e4ae41f8
Conform more of the codebase to strictNullChecks (#10607)
* Conform more of the codebase to `strictNullChecks`

* Conform more of the codebase to `strictNullChecks`

* Fix types

* Conform more of the codebase to `strictNullChecks`

* Conform more of the codebase to `strictNullChecks`
2023-04-17 09:25:00 +01:00
Suguru Hirahara 9d8d610f31
Update `room.spec.ts` - use Cypress Testing Library (#10608)
* Update room.spec.ts - use Cypress Testing Library

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Empty commit

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-17 07:35:14 +00:00
Suguru Hirahara 8a4a584ba0
Make test ID compatible with findByTestId() of Cypress Testing Library (#10617)
'data-test-id' is not discoverable with findByTestId() of Cypress Testing Library.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-17 06:10:11 +00:00
Michael Telatynski daad630827
Conform more of the codebase to `strictNullChecks` (#10602)
* Conform more of the codebase to `strictNullChecks`

* Conform more of the codebase to `strictNullChecks`

* Fix types
2023-04-17 08:31:58 +01:00
Suguru Hirahara 93858813a3
Update stickers.spec.ts - use Cypress Testing Library (#10622)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-17 05:56:37 +00:00
Rashmit Pankhania 7751f9c622
#21451 Fix WebGL disabled error message (#10589)
* #21451 Fix WebGl disabled error message

* #21451 Fix WebGl disabled error message

Signed-off-by: Rashmit Pankhania <rashmitpankhania@gmail.com>
Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>

* Fix message

Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>

* Fix ordering of cases in LocationShareErrors.ts

Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>

* Fix linting LocationPicker.tsx

Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>

* Fix eslint

Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>

* Fix file encoding for i18n CI issue

Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>

* Fix ts strict CI issue

Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>

---------

Signed-off-by: Rashmit Pankhania <rashmitpankhania@gmail.com>
Signed-off-by: Rashmit Pankhania <raspankh@publicisgroupe.net>
Co-authored-by: Rashmit Pankhania <raspankh@publicisgroupe.net>
Co-authored-by: Kerry <kerrya@element.io>
2023-04-17 04:25:04 +00:00
Suguru Hirahara 41c0b0881a
Update pills-click-in-app.spec.ts - use Cypress Testing Library (#10582)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-16 22:50:57 +00:00
Michael Telatynski 439759a1da
Relate field validation tooltip via aria-describedby (#10522)
* Relate field validation tooltip via aria-describedby

* Iterate
2023-04-14 14:15:26 +00:00
Eric Eastwood c1e7905ddc
Properly translate errors in `AddThreepid.ts` (#10432)
* Properly translate errors in AddThreepid.ts

Part of https://github.com/vector-im/element-web/issues/9597

* Use translated message

* Avoid returning undefined ever

* More usage

* Introduce UserFriendlyError

* Use UserFriendlyError

* Add more usage instead of normal error

* Use types and translatedMessage

* Fix lints

* Update i18n although it's wrong

* Use unknown for easier creation from try/catch

* Use types

* Use error types

* Use types

* Update i18n strings

* Remove generic re-label of HTTPError

See https://github.com/matrix-org/matrix-react-sdk/pull/10432#discussion_r1156468143

The HTTPError already has a good label and it isn't even translated if we re-label it here in this way generically

Probably best to just remove in favor of thinking about a translations in general from the `matrix-js-sdk`, see https://github.com/matrix-org/matrix-js-sdk/issues/1309

* Make error message extraction generic

* Update i18n strings

* Add tests for email addresses

* More consistent error logging to actually see error in logs

* Consistent error handling

* Any is okay because we have a fallback

* Check error type

* Use dedicated mockResolvedValue function

See https://github.com/matrix-org/matrix-react-sdk/pull/10432#discussion_r1163344034
2023-04-14 15:40:19 +01:00
Michael Telatynski 8f8b74b32c
Fix overflow on auth pages (#10605) 2023-04-14 14:15:21 +00:00
Julien DAUPHANT 075c8c3d33
Fix bug on Avatar.ts for custom theme avatar background color (#10598) 2023-04-14 13:38:54 +00:00
Suguru Hirahara 256c3591aa
Update login.spec.ts - use Cypress Testing Library (#10597)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-14 11:40:43 +00:00
Michael Weimann bdd6d8d661
Add support for Cypress tests with Podman (#10603) 2023-04-14 11:02:59 +00:00
Richard van der Hoff 6b451afc50
Remove dependency on `org.matrix.e2e_cross_signing` unstable feature (#10593)
* Remove dependency on `org.matrix.e2e_cross_signing` unstable feature

Currently, we have some code that relies on the server declaring support for an
`unstable_feature` called `org.matrix.e2e_cross_signing`. There is nothing in
the spec that requires this, so this would make us incompatible with some
server implementations.

The features in question were added in spec v1.1, so we can test for that
instead.

* fix unit test
2023-04-14 10:14:05 +00:00
Richard van der Hoff 70b87f8bde
Simplify `isDeviceVerified` definitions (#10594)
* Simplify `isDeviceVerified` definitions

Currently, we have two similar but different definitions of `isDeviceVerified`,
and they both do a lot of wrangling that relies on js-sdk internals. We can
simplify it a lot by just calling `MatrixClientPeg.checkDeviceTrust`.

* fix tests

* more test fixes
2023-04-14 09:46:37 +00:00
alunturner e4ebcf5731
Handle more completion types in rte autocomplete (#10560)
* handle at-room

* remove console log

* update and add tests

* tidy up

* refactor to switch statement

* fix TS error

* expand tests

* consolidate similar if/else if blocks
2023-04-14 09:09:38 +00:00
Michael Telatynski 1ae0662872
Update setting description to match reality (#10600) 2023-04-14 08:58:08 +00:00
Suguru Hirahara 72fe394e4c
Update kick.spec.ts - use Cypress Testing Library (#10587)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-13 10:08:39 +00:00
Michael Telatynski 605ef084ec
Conform more of the codebase to `strictNullChecks` (#10573)
* Conform more of the codebase to `strictNullChecks`

* Iterate
2023-04-13 08:52:57 +01:00
Michael Telatynski b4d7f6b592
Fix no identity server in help & about settings (#10563) 2023-04-13 07:25:51 +00:00
Suguru Hirahara a2c2c01edc
Update get-openid-token.spec.ts - use Cypress Testing Library (#10586)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-13 06:27:39 +00:00
Suguru Hirahara 747afec27e
Use `AccessibleButton` for "Accept" on AuthPage (#10508)
* Use AccessibleButton for "Accept" on AuthPage

- Use AccessibleButton
- Remove mx_InteractiveAuthEntryComponents_termsSubmit:disabled as disabled state is handled by AccessibleButton

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Empty commit

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-13 01:29:09 +00:00
Kerry 6280395928
Fix: Images no longer reserve their space in the timeline correctly (#10571)
* test case

* fix + lint

* refix strictNullChecks issue

* add comment about max image size

* tweak

* use safer magic number
2023-04-13 01:22:16 +00:00
Suguru Hirahara 9b8459e8e9
Update device-management.spec.ts - use Cypress Testing Library (#10585)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-12 15:58:28 +00:00
Suguru Hirahara c5de595e79
Update `user-view.spec.ts` - use Cypress Testing Library (#10577)
* Update user-view.spec.ts - use Cypress Testing Library

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove a line to have the test wait until the spinner disappears

The custom command 'percySnapshotElement' waits until it disappears so there is no need to keep it.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-12 15:55:10 +00:00
Suguru Hirahara c9c974d455
Use Cypress Testing Library - `crypto.spec.ts` (#10512)
* Update crypto.spec.ts - use Cypress Testing Library

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Empty commit

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-12 15:48:31 +00:00
Andy Balaam c496985ff3
Show a tile for an unloaded predecessor room if it has via_servers (#10483)
* Improve typing in constructor of RoomPermalinkCreator

* Provide via servers if present when navigating to predecessor room from Advanced Room Settings

* Show an error tile when the predecessor room is not found

* Test for MatrixToPermalinkConstructor.forRoom

* Test for MatrixToPermalinkConstructor.forEvent

* Display a tile for predecessor event if it contains via servers

* Fix missing case where event id is provided as well as via servers

* Refactor RoomPredecessor tests

* Return lost filterConsole to its home

* Comments for IState in AdvancedRoomSettingsTab

* Explain why we might render a tile even without prevRoom

* Guess the old room's via servers if they are not provided

* Fix TypeScript errors

* Adjust regular expression (hopefully) to avoid potential catastrophic backtracking

* Another attempt at avoiding super-liner regex performance

* Tests for guessServerNameFromRoomId and better implementation

* Further attempt to prevent backtracking

---------

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2023-04-12 15:26:45 +00:00
Michael Telatynski 075cb9e622
Exclude message timestamps from aria live region (#10584)
* Exclude message timestamps from aria live region

* Update snapshot
2023-04-12 14:12:45 +00:00
Michael Telatynski e5b1b7b632
Make composer format bar an aria toolbar (#10583)
* Make composer format bar an aria toolbar

* Iterate

* Iterate

* Update snapshot
2023-04-12 13:58:38 +00:00
Suguru Hirahara d179956af8
Update one-to-one-chat.spec.ts - use Cypress Testing Library (#10572)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-12 13:11:28 +00:00
Suguru Hirahara c9599a3ef2
Update user-menu.spec.ts - use Cypress Testing Library (#10578)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-12 12:56:34 +00:00
Michael Telatynski 287a3fd0cf
Fix issues with inhibited accessible focus outlines (#10579) 2023-04-12 12:49:12 +00:00
Richard van der Hoff ec83855938
Fix jest config on develop (#10580)
#10569 broke it
2023-04-12 12:44:25 +00:00
Michael Telatynski 9c19cd48fe
Fix github actions deprecations warnings (#10575) 2023-04-12 12:06:30 +00:00
Michael Weimann 7cd86231b4
Fix read receipts falling from sky (#10576) 2023-04-12 11:50:48 +00:00
Michael Telatynski d2066ba5f5
Improve accessibility of font slider (#10473)
* Clamp font size when disabling "Use custom size"

* Switch Slider to use a semantic input range element

* Iterate

* delint

* delint

* snapshot

* Iterate

* Iterate

* Fix step size

* Add focus outline to slider

* Derp
2023-04-12 10:57:31 +00:00
Suguru Hirahara bef6eca484
Update tests to ensure file size unit has been fixed (#10568)
* Update tests to ensure file size unit has been fixed

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Update cypress/e2e/timeline/timeline.spec.ts

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* Edit comments mentioning kilobytes

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2023-04-12 10:21:13 +00:00
Richard van der Hoff 3c4fa8b430
Improve output in github actions for jest tests (#10569) 2023-04-12 09:47:39 +00:00
Suguru Hirahara 5316bb58f7
Remove find.ts and custom commands on Cypress Testing Library (#10544)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-12 07:26:12 +00:00
Suguru Hirahara b5493680ce
Update `register.spec.ts` - use Cypress Testing Library (#10566)
* Update register.spec.ts - use Cypress Testing Library

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* findByRole - checkbox

<input type='checkbox'> has implicit ARIA 'checkbox' role

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-11 17:37:05 +00:00
renovate[bot] 86a2d78318
Lock file maintenance (#10557)
* Lock file maintenance

* Pin jest

* Pin back jest-canvas-mock

* Roll back jest

* Roll back jest

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2023-04-11 14:19:43 +00:00
Neeraj Vageele ce0bd00c5b
fix file size display from kB to KB (#10561)
* fix file size display from kB to KB

* add a wrapper function for filesize

---------

Co-authored-by: Neeraj <neerajv@thirdrocktechkno.com>
2023-04-11 14:48:41 +01:00
RiotRobot 8a150252bf Reset matrix-js-sdk back to develop branch 2023-04-11 14:07:05 +01:00
RiotRobot 8e9cd74dbc Resetting package fields for development 2023-04-11 14:06:11 +01:00
RiotRobot f9ab9fe8ce Merge branch 'master' into develop 2023-04-11 14:06:04 +01:00
RiotRobot 52f5d8c2d1 v3.70.0 2023-04-11 14:05:47 +01:00
RiotRobot c6284936f0 Prepare changelog for v3.70.0 2023-04-11 14:05:44 +01:00
RiotRobot cd2ea18eee Upgrade matrix-js-sdk to 24.1.0 2023-04-11 14:03:56 +01:00
Suguru Hirahara 65f605951f
Update `timeline.spec.ts` (#10540)
* timeline.spec.ts - deprecate custom commands of find.ts

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Iterate

- clickButtonReply()
- findByText()

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-04-11 10:33:32 +00:00
Hugh Nimmo-Smith 692c07ef0a
Use Capabilities type from js-sdk (#10535) 2023-04-11 09:46:11 +00:00