chg: [bookmarks] Make the rendering more lenient to malformed content

- fail gracefully rather than throwing 500s
2024-09-17 00:08:49 +02:00 · 2024-09-17 00:08:49 +02:00 · 8e3e4316fb
parent eb3f725e5b
commit 8e3e4316fb
1 changed files with 6 additions and 1 deletions
--- a/src/Controller/Component/NavigationComponent.php
+++ b/src/Controller/Component/NavigationComponent.php
@ -74,8 +74,13 @@ class NavigationComponent extends Component
        $userSettingTable = TableRegistry::getTableLocator()->get('UserSettings');
        $setting = $userSettingTable->getSettingByName($this->request->getAttribute('identity'), 'ui.bookmarks');
        $bookmarks = is_null($setting) ? [] : json_decode($setting->value, true);
-
+        if (empty($bookmarks)) {
+            return [];
+        }
        $links = array_map(function($bookmark) {
+            if (!isset($bookmark['name']) || !isset($bookmark['label']) || !isset($bookmark['url'])) {
+                return [];
+            }
            return [
                'name' => $bookmark['name'],
                'label' => $bookmark['label'],